Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maint] Update build_napari.yml to drop doctrees #160

Merged

Conversation

psobolewskiPhD
Copy link
Member

In napari/docs#348 the build of docs was changed slightly to not put the doctrees in the html output.
In this PR I alter the workflow that builds napari docs using the theme to account for this change.
We don't need to delete the doctrees anymore, we can just upload the html folder instead.

@psobolewskiPhD
Copy link
Member Author

psobolewskiPhD commented Mar 28, 2024

So the artifact build and uploaded correctly here. I checked the action page and clicked workflow file:
https://github.com/napari/napari-sphinx-theme/actions/runs/8460246134/workflow?pr=160
it is the one from here, this pr not the one from main.
So I think all the paths and everything are correct for the change in the Makefile.
In napari/docs#380 I use the same paths, with .../html/

@psobolewskiPhD psobolewskiPhD requested a review from melissawm April 7, 2024 15:48
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is right and we should give it a go. Thanks, @psobolewskiPhD !

@melissawm melissawm added enhancement New feature or request ready to merge labels Apr 11, 2024
@psobolewskiPhD psobolewskiPhD merged commit c8fe158 into napari:main Apr 12, 2024
1 check passed
melissawm pushed a commit to melissawm/napari-sphinx-theme that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants