Allow arbitrary menu locations in npe2 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1717 1707 -10
=========================================
- Hits 1717 1707 -10
Continue to review full report at Codecov.
|
kne42
approved these changes
May 8, 2022
tlambert03
added a commit
to tlambert03/npe2
that referenced
this pull request
Jun 12, 2022
This reverts commit 5587f4f.
tlambert03
added a commit
that referenced
this pull request
Jun 13, 2022
tlambert03
added a commit
that referenced
this pull request
Jun 13, 2022
…ems (#175) * Revert "Allow arbitrary menu locations in npe2 (#160)" This reverts commit 5587f4f. * change menus contribution to dict * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix bad merge * fix test Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #159 which allows for arbitrary menu locations in npe2. The validation would now happen in napari, or in subsequent PRs. The main change is to drop
MenusContribution, and instead just have a dict, which allows us to use keys that are strings containing/and so we don't need to do any menu coercion.This PR came from recommendations of @nclack and @tlambert03 after reviewing #159 in person together at the napari hackathon. cc @kne42 @Carreau