Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential error with npe2 cache --list with uninstalled plugin #165

Merged
merged 1 commit into from
May 25, 2022

Conversation

tlambert03
Copy link
Collaborator

calling distribution() on an uninstalled plugin is an error. This PR just uses mf.package_version instead, which will catch the error

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #165 (fd1cefe) into main (98281e6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1732      1730    -2     
=========================================
- Hits          1732      1730    -2     
Impacted Files Coverage Δ
npe2/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98281e6...fd1cefe. Read the comment docs.

Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tlambert03 tlambert03 merged commit a62249c into napari:main May 25, 2022
@tlambert03 tlambert03 deleted the fix-missing-cache branch May 25, 2022 17:04
@tlambert03 tlambert03 added the bug Something isn't working label Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants