Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writer order preference #172

Merged
merged 6 commits into from
Jun 12, 2022
Merged

Conversation

tlambert03
Copy link
Collaborator

@tlambert03 tlambert03 commented Jun 12, 2022

fixes #129, ensuring that – all else being equal – writers declared earlier in a plugin's manifest have priority over later ones

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #172 (7d89e4d) into main (a483aea) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1730      1728    -2     
=========================================
- Hits          1730      1728    -2     
Impacted Files Coverage Δ
npe2/_plugin_manager.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a483aea...7d89e4d. Read the comment docs.

Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Looks like there's some dead code that should be removed.

npe2/_plugin_manager.py Show resolved Hide resolved
@tlambert03 tlambert03 merged commit 5b46570 into napari:main Jun 12, 2022
@tlambert03 tlambert03 deleted the fix-writer-order branch June 12, 2022 12:58
@tlambert03 tlambert03 added the bug Something isn't working label Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any way to allow a plugin control over it's writer priority?
2 participants