Fail silently when caching throws OSError
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #184 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1794 1796 +2
=========================================
+ Hits 1794 1796 +2
Continue to review full report at Codecov.
|
tlambert03
changed the title
OSError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving to cache with the current
cache_pathcould (rarely) throw anOSErrorif the user didn't have permission to write to/home. We have run into this on the napari hub when working in a Docker image that only allows us to write to/tmp.Since caching is just a convenience, this PR catches
OSErroron caching and fails silently.