Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npe2 list command to discover/display all currently installed plugins #192

Merged
merged 13 commits into from
Jun 25, 2022

Conversation

tlambert03
Copy link
Collaborator

work in progress, but here's the idea:

Screen Shot 2022-06-21 at 9 08 15 PM

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #192 (1325ac0) into main (aba218b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         2101      2178   +77     
=========================================
+ Hits          2101      2178   +77     
Impacted Files Coverage Δ
npe2/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba218b...1325ac0. Read the comment docs.

@nclack
Copy link
Collaborator

nclack commented Jun 24, 2022

I find myself using this constantly fwiw. will need rich in the install_requires?

@tlambert03
Copy link
Collaborator Author

I find myself using this constantly fwiw.

what do you mean? Like, you check out this branch and run it? 😂 if so we need to get this in for you :)

will need rich in the install_requires?

Yep, will do thanks.

@tlambert03 tlambert03 marked this pull request as ready for review June 24, 2022 12:01
@tlambert03
Copy link
Collaborator Author

Ok, need to add tests and more docs, but i think the implementation is roughly where I'd have it, so marking ready for first review. I added an optional --format flag.

Screen Shot 2022-06-24 at 8 02 23 AM

Screen Shot 2022-06-24 at 8 02 42 AM

Screen Shot 2022-06-24 at 8 02 54 AM

@tlambert03 tlambert03 changed the title [wip] Add npe2 list command to discover/display all currently installed plugins Add npe2 list command to discover/display all currently installed plugins Jun 24, 2022
@tlambert03
Copy link
Collaborator Author

I've merged in #197 here, so that should be reviewed first. I also added docs and cleaned this up a bit. So the only thing left now is to complete test coverge

Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great.

@tlambert03 tlambert03 enabled auto-merge (squash) June 25, 2022 02:09
@tlambert03 tlambert03 merged commit 7f29565 into napari:main Jun 25, 2022
@tlambert03 tlambert03 deleted the npe2-list branch June 25, 2022 02:11
@tlambert03 tlambert03 added the enhancement New feature or request label Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants