Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing-extensions imports #193

Merged
merged 2 commits into from
Jun 25, 2022

Conversation

tlambert03
Copy link
Collaborator

We had some from typing_extensions imports, but didn't have it listed in our dependencies. It's something that ends up being in almost every environment, so we didn't have any issues yet (I guess), but it should have been listed in deps. Turns out though, that everything we were importing there is now available in python >=3.8, so this PR just changes those imports to from typing

@tlambert03 tlambert03 marked this pull request as ready for review June 22, 2022 12:22
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #193 (e7b3c11) into main (2323319) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         2106      2101    -5     
=========================================
- Hits          2106      2101    -5     
Impacted Files Coverage Δ
npe2/_dynamic_plugin.py 100.00% <ø> (ø)
npe2/manifest/utils.py 100.00% <ø> (ø)
npe2/types.py 100.00% <ø> (ø)
npe2/io_utils.py 100.00% <100.00%> (ø)
npe2/manifest/_package_metadata.py 100.00% <100.00%> (ø)
npe2/manifest/contributions/_themes.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2323319...e7b3c11. Read the comment docs.

@tlambert03 tlambert03 closed this Jun 23, 2022
@tlambert03 tlambert03 reopened this Jun 23, 2022
Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tlambert03 tlambert03 enabled auto-merge (squash) June 25, 2022 00:25
@tlambert03 tlambert03 merged commit aba218b into napari:main Jun 25, 2022
@tlambert03 tlambert03 deleted the remove-typing-extensions branch June 25, 2022 00:29
@tlambert03 tlambert03 added the dependencies Pull requests that update a dependency file label Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants