Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setuptools plugin to compile manifest at build #194

Merged
merged 81 commits into from
Dec 17, 2022
Merged

Add setuptools plugin to compile manifest at build #194

merged 81 commits into from
Dec 17, 2022

Conversation

tlambert03
Copy link
Collaborator

This PR adds the ability to compile all @npe2.implements decorators down to a manifest yaml automatically at build time by adding the following to pyproject.toml.

# pyproject.toml
[build-system]
requires = ["setuptools", "wheel", "npe2"]
build-backend = "setuptools.build_meta"

[tool.npe2]

it includes #186

tlambert03 and others added 30 commits December 20, 2021 19:19
@tlambert03
working decorators!
bb5e67f
@tlambert03
change sample plugin name
86d8ab4
@tlambert03
Merge branch 'change-sample-plugin-name' into decorators
bc8134c
@tlambert03
move and simplify sample
30861e1
@tlambert03
add tests
fb27028
@tlambert03
add import test
72d1c3b
@tlambert03
add pragma
044558d
@tlambert03
Merge branch 'main' into decorators
869f8f6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e1b9340 
for more information, see https://pre-commit.ci
@tlambert03
Merge branch 'main' into decorators
7a26548
@tlambert03
visit returns contrib points
0b4cd00
@tlambert03
more docs
de85e2c
@tlambert03
add type stubs
9f4d302
@tlambert03
remove excludes from setup
30e6255
@tlambert03
fix tests
fb9cff9
@tlambert03
add compile func
c6d9f89
@tlambert03
Merge branch 'main' into decorators
2f8a804
@tlambert03
Merge branch 'main' into decorators
5284e9c
@tlambert03
Merge branch 'decorators' into compile
d50eaf9
@tlambert03
Merge branch 'main' into decorators
986b8ca
@tlambert03
Merge branch 'decorators' into compile
cf01c2a
@tlambert03
Merge branch 'main' into compile
da12d61
@tlambert03
add __all__
786b87f
@tlambert03
adding comments support
615faea
@tlambert03
add ensure_args_valid = False
2a8c46b
@tlambert03
suppress any potential errors
b5574f6
@tlambert03
Merge branch 'update-implements' into compile
44e0e42
@tlambert03
add import
c11fb2f
@tlambert03
Merge branch 'main' into compile
82a0442
@tlambert03
remove comments code, add type_checking example
5237ebf
@tlambert03 tlambert03 mentioned this pull request Aug 3, 2022
Merged
@tlambert03 tlambert03 changed the title [WIP] Add setuptools plugin to compile manifest at build Add setuptools plugin to compile manifest at build Dec 16, 2022
@tlambert03 tlambert03 marked this pull request as ready for review December 16, 2022 23:42
nclack
nclack approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay. lgtm.

@nclack nclack merged commit 5a13214 into napari:main Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nclack nclack nclack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlambert03 @nclack