Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npe2 list when a dotted field key is empty #203

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

tlambert03
Copy link
Collaborator

Fixes a bug when a dotted field name has been requested in npe2 list (such as package_metadata.version) if one of the upper level names doesn't exist (i.e. if package_metadata is None)

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #203 (49106ef) into main (726bd5b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #203   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         2179      2179           
=========================================
  Hits          2179      2179           
Impacted Files Coverage Δ
npe2/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726bd5b...49106ef. Read the comment docs.

Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'm going to go ahead and merge

@nclack nclack merged commit 6541f37 into napari:main Jun 27, 2022
@tlambert03 tlambert03 added the bug Something isn't working label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants