Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alternate fix for dotted plugin_name #238

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

tlambert03
Copy link
Collaborator

alternative to #233

@nclack, this implements option 1 from #233 (comment)

it populates Executable._plugin_name during the PluginManifest.__init__, and falls back to option 4 if nothing has been set (i.e. if it's a one-off contribution), and then lastly, to the old period split if nothing is found to be installed

@codecov
Copy link

codecov bot commented Aug 13, 2022

Codecov Report

Merging #238 (efea475) into main (a853b4e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #238   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2742      2753   +11     
=========================================
+ Hits          2742      2753   +11     
Impacted Files Coverage Δ
npe2/manifest/contributions/_readers.py 100.00% <100.00%> (ø)
npe2/manifest/contributions/_sample_data.py 100.00% <100.00%> (ø)
npe2/manifest/contributions/_widgets.py 100.00% <100.00%> (ø)
npe2/manifest/contributions/_writers.py 100.00% <100.00%> (ø)
npe2/manifest/schema.py 100.00% <100.00%> (ø)
npe2/manifest/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy cow this is amazing.

@tlambert03 tlambert03 merged commit 3ead8db into napari:main Aug 15, 2022
@tlambert03 tlambert03 deleted the fix-name branch August 15, 2022 10:34
@kmdouglass
Copy link

Thanks again @tlambert03 and @nclack !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants