Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pre-commit, use ruff and fix mypy #273

Merged
merged 5 commits into from
Feb 28, 2023

Conversation

tlambert03
Copy link
Collaborator

@tlambert03 tlambert03 commented Feb 27, 2023

closes #260

closes #272

@tlambert03 tlambert03 requested a review from Czaki February 27, 2023 22:33
@tlambert03
Copy link
Collaborator Author

since pre-commit was failing on #272, this fixes it, and also does what #272 was doing

Copy link
Collaborator

@Czaki Czaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion.
It looks like I do not have permissions in this repository.

pyproject.toml Show resolved Hide resolved
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
pyproject.toml Show resolved Hide resolved
@tlambert03
Copy link
Collaborator Author

i'm about to head out. you should have merge permissions now

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #273 (cdf23f8) into main (eb535a4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2814      2813    -1     
=========================================
- Hits          2814      2813    -1     
Impacted Files Coverage Δ
npe2/_command_registry.py 100.00% <ø> (ø)
npe2/_plugin_manager.py 100.00% <ø> (ø)
npe2/io_utils.py 100.00% <ø> (ø)
npe2/_inspection/_compile.py 100.00% <100.00%> (ø)
npe2/_inspection/_fetch.py 100.00% <100.00%> (ø)
npe2/_inspection/_from_npe1.py 100.00% <100.00%> (ø)
npe2/_inspection/_setuputils.py 100.00% <100.00%> (ø)
npe2/_inspection/_visitors.py 100.00% <100.00%> (ø)
npe2/cli.py 100.00% <100.00%> (ø)
npe2/implements.py 100.00% <100.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlambert03
Copy link
Collaborator Author

merging this to try to fix napari/napari#5592 (comment)

@tlambert03 tlambert03 merged commit c4acdd8 into napari:main Feb 28, 2023
@tlambert03 tlambert03 deleted the update-precommit branch February 28, 2023 01:23
@tlambert03 tlambert03 added the tests related to testing or CI label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests related to testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants