add graph layer #292
Merged
add graph layer #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2788 2790 +2
=========================================
+ Hits 2788 2790 +2
|
|
Ah, too bad I only see this now, already had a branch on this (but no PR)... https://github.com/jwindhager/npe2/tree/graph-layer I'll check whether there are any differences and report back! |
|
Indeed, there seem to be a few changes missing. I'll contribute them to this PR tomorrow EDIT: done, see JoOkuma#1 |
|
Thanks, @jwindhager , I merged your PR to my branch. |
jni
approved these changes
Jun 27, 2023
|
@nclack I don't really know this repo 😅 so if you could review+merge that would be great. 😊 |
nclack
reviewed
Jul 4, 2023
Co-authored-by: Jonas Windhager <jonas@windhager.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR adds "graph" to the list of existing layers.
It's required by PR napari/napari#5861 which adds a new napari graph layer.