Catch errors and log in _dispose in PluginContext
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2774 2779 +5
=========================================
+ Hits 2774 2779 +5 ☔ View full report in Codecov by Sentry. |
|
@lucyleeow thanks for opening! The failures are unrelated and I think should be addressed in a separate PR. However, it would be good to add a test for the dispose bit to get coverage back up to 100 |
|
@DragaDoncila I think this is ready for review now, test added! |
DragaDoncila
approved these changes
Nov 24, 2023
|
Maybe this could go in now...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the dispose functions in
_disposeinPluginContext, catch errors and log instead of raising.Suggested by Talley in: pyapp-kit/app-model#147 (comment)