-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NPE1Shim, to convert npe1 plugins to the npe2 interface #86
Conversation
Codecov Report
@@ Coverage Diff @@
## main #86 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 23 24 +1
Lines 1355 1583 +228
==========================================
+ Hits 1355 1583 +228
Continue to review full report at Codecov.
|
There was some good discussion in the plugin working group meeting. See notes. Most of the discussion was around the caching behavior. We discussed disable/uninstall support being tied to this which I think is great but probably a follow up pr? |
OK @nclack, @Carreau, this is now ready to go. Due to the many moving parts, this has unfortunately ballooned into a massive PR. So I broke it up into three PRs.
each PR contains the previous one... and #126 should actually be identical to this one. If you prefer, you can also simply review this one (and I would just close those PRs). The whole thing can be tested in concert by checking out this branch (or the branch from #126) along with napari/napari#4015 |
Still experimenting, but this PR would
a) discover npe1 plugins along with npe2 during the discovery process
b) have some sort of way to generate a manifest from the entrypoints (using same logic as
npe2 convert
)c) cache that manifest for use on later launches
this could be used to help us transition to npe2 being the only plugin manager