Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #922

Merged
merged 1 commit into from
May 7, 2024
Merged

Update index.d.ts #922

merged 1 commit into from
May 7, 2024

Conversation

k-nero
Copy link
Contributor

@k-nero k-nero commented Apr 28, 2024

added string array to langs type

@Balearica
Copy link
Member

Thanks for this contribution, merging now.

Other users have requested that language parameters be validated, so I'm not sure that allowing arbitrary strings is the best option long-term. However, I agree that this is better than what we currently have, and if a single string is valid then an array of strings should also be valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants