Skip to content

Commit

Permalink
Rename value_extractor to input_modifier (#110)
Browse files Browse the repository at this point in the history
  • Loading branch information
nardew authored Dec 29, 2023
1 parent 485c20d commit 3991e1b
Show file tree
Hide file tree
Showing 56 changed files with 186 additions and 186 deletions.
6 changes: 3 additions & 3 deletions talipp/indicators/ADX.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from talipp.indicator_util import has_valid_values
from talipp.indicators.ATR import ATR
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -22,8 +22,8 @@ class ADX(Indicator):
"""

def __init__(self, di_period: int, adx_period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None,
value_extractor: ValueExtractorType = None):
super().__init__(value_extractor=value_extractor, output_value_type=ADXVal)
input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier, output_value_type=ADXVal)

self.di_period = di_period
self.adx_period = adx_period
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/ALMA.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from math import exp
from typing import List, Any

from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType


class ALMA(Indicator):
Expand All @@ -11,8 +11,8 @@ class ALMA(Indicator):
Output: a list of floats
"""

def __init__(self, period: int, offset: float, sigma: float, input_values: List[float] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
def __init__(self, period: int, offset: float, sigma: float, input_values: List[float] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.period = period
self.offset = offset
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/AO.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ma import MAType, MAFactory
from talipp.ohlcv import OHLCV

Expand All @@ -14,8 +14,8 @@ class AO(Indicator):
"""

def __init__(self, fast_period: int, slow_period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None,
value_extractor: ValueExtractorType = None, ma_type: MAType = MAType.SMA):
super().__init__(value_extractor=value_extractor)
input_modifier: InputModifierType = None, ma_type: MAType = MAType.SMA):
super().__init__(input_modifier=input_modifier)

self.fast_period = fast_period
self.slow_period = slow_period
Expand Down
4 changes: 2 additions & 2 deletions talipp/indicators/ATR.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -12,7 +12,7 @@ class ATR(Indicator):
Output: a list of floats
"""

def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super(ATR, self).__init__()

self.period = period
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/AccuDist.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -12,8 +12,8 @@ class AccuDist(Indicator):
Output: a list of floats
"""

def __init__(self, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
def __init__(self, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.initialize(input_values, input_indicator)

Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/Aroon.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -19,8 +19,8 @@ class Aroon(Indicator):
Output: a list of AroonVal
"""

def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor, output_value_type=AroonVal)
def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier, output_value_type=AroonVal)

self.period = period

Expand Down
10 changes: 5 additions & 5 deletions talipp/indicators/BB.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.indicators.StdDev import StdDev
from talipp.ma import MAType, MAFactory

Expand All @@ -27,15 +27,15 @@ class BB(Indicator):
"""

def __init__(self, period: int, std_dev_mult: float, input_values: List[float] = None,
input_indicator: Indicator = None, value_extractor: ValueExtractorType = None,
input_indicator: Indicator = None, input_modifier: InputModifierType = None,
ma_type: MAType = MAType.SMA):
super().__init__(value_extractor=value_extractor, output_value_type=BBVal)
super().__init__(input_modifier=input_modifier, output_value_type=BBVal)

self.period = period
self.std_dev_mult = std_dev_mult

self.central_band = MAFactory.get_ma(ma_type, period, value_extractor=value_extractor)
self.std_dev = StdDev(self.period, value_extractor = value_extractor)
self.central_band = MAFactory.get_ma(ma_type, period, input_modifier=input_modifier)
self.std_dev = StdDev(self.period, input_modifier=input_modifier)

self.add_sub_indicator(self.central_band)
self.add_sub_indicator(self.std_dev)
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/BOP.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import List, Any

from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -11,8 +11,8 @@ class BOP(Indicator):
Output: a list of floats
"""

def __init__(self, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
def __init__(self, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.initialize(input_values, input_indicator)

Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/CCI.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.indicators.MeanDev import MeanDev
from talipp.ohlcv import OHLCV

Expand All @@ -13,8 +13,8 @@ class CCI(Indicator):
Output: a list of OHLCV objects
"""

def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.mean_dev = MeanDev(period)
self.add_managed_sequence(self.mean_dev)
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/CHOP.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from talipp.indicator_util import has_valid_values
from talipp.indicators.ATR import ATR
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -14,8 +14,8 @@ class CHOP(Indicator):
Output: a list of OHLCV objects
"""

def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.period = period

Expand Down
10 changes: 5 additions & 5 deletions talipp/indicators/ChaikinOsc.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from talipp.indicator_util import has_valid_values
from talipp.indicators.AccuDist import AccuDist
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ma import MAType, MAFactory
from talipp.ohlcv import OHLCV

Expand All @@ -15,19 +15,19 @@ class ChaikinOsc(Indicator):
"""

def __init__(self, fast_period: int, slow_period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None,
value_extractor: ValueExtractorType = None, ma_type: MAType = MAType.EMA):
super().__init__(value_extractor = value_extractor)
input_modifier: InputModifierType = None, ma_type: MAType = MAType.EMA):
super().__init__(input_modifier=input_modifier)

self.fast_period = fast_period
self.slow_period = slow_period

self.accu_dist = AccuDist()
self.add_sub_indicator(self.accu_dist)

self.ma_fast = MAFactory.get_ma(ma_type, fast_period, value_extractor=value_extractor)
self.ma_fast = MAFactory.get_ma(ma_type, fast_period, input_modifier=input_modifier)
self.add_managed_sequence(self.ma_fast)

self.ma_slow = MAFactory.get_ma(ma_type, slow_period, value_extractor=value_extractor)
self.ma_slow = MAFactory.get_ma(ma_type, slow_period, input_modifier=input_modifier)
self.add_managed_sequence(self.ma_slow)

self.initialize(input_values, input_indicator)
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/ChandeKrollStop.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from talipp.indicator_util import has_valid_values
from talipp.indicators import ATR
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -20,8 +20,8 @@ class ChandeKrollStop(Indicator):
Output: a list of ChandeKrollStopVal objects
"""

def __init__(self, atr_period: int, atr_mult: float, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor, output_value_type=ChandeKrollStopVal)
def __init__(self, atr_period: int, atr_mult: float, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier, output_value_type=ChandeKrollStopVal)

self.atr_period = atr_period
self.atr_mult = atr_mult
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/CoppockCurve.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.indicators.ROC import ROC
from talipp.indicators.WMA import WMA

Expand All @@ -14,8 +14,8 @@ class CoppockCurve(Indicator):
"""

def __init__(self, fast_roc_period: int, slow_roc_period: int, wma_period: int,
input_values: List[float] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
input_values: List[float] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.fast_roc = ROC(fast_roc_period)
self.add_sub_indicator(self.fast_roc)
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/DEMA.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from talipp.indicator_util import has_valid_values
from talipp.indicators.EMA import EMA
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType


class DEMA(Indicator):
Expand All @@ -12,8 +12,8 @@ class DEMA(Indicator):
Output: a list of floats
"""

def __init__(self, period: int, input_values: List[float] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
def __init__(self, period: int, input_values: List[float] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.period = period

Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/DPO.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ma import MAType, MAFactory


Expand All @@ -13,8 +13,8 @@ class DPO(Indicator):
"""

def __init__(self, period: int, input_values: List[float] = None, input_indicator: Indicator = None,
value_extractor: ValueExtractorType = None, ma_type: MAType = MAType.SMA):
super().__init__(value_extractor = value_extractor)
input_modifier: InputModifierType = None, ma_type: MAType = MAType.SMA):
super().__init__(input_modifier=input_modifier)

self.period = period

Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/DonchianChannels.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ohlcv import OHLCV


Expand All @@ -24,8 +24,8 @@ class DonchianChannels(Indicator):
Output: a list of DonnchianChannelsVal
"""
def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor, output_value_type=DonchianChannelsVal)
def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier, output_value_type=DonchianChannelsVal)

self.period = period

Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/EMA.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType


class EMA(Indicator):
Expand All @@ -11,8 +11,8 @@ class EMA(Indicator):
Output: a list of floats
"""

def __init__(self, period: int, input_values: List[float] = None, input_indicator: Indicator = None, value_extractor: ValueExtractorType = None):
super().__init__(value_extractor = value_extractor)
def __init__(self, period: int, input_values: List[float] = None, input_indicator: Indicator = None, input_modifier: InputModifierType = None):
super().__init__(input_modifier=input_modifier)

self.period = period

Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/EMV.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ma import MAType, MAFactory
from talipp.ohlcv import OHLCV

Expand All @@ -14,8 +14,8 @@ class EMV(Indicator):
"""

def __init__(self, period: int, volume_div: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None,
value_extractor: ValueExtractorType = None, ma_type: MAType = MAType.SMA):
super().__init__(value_extractor = value_extractor)
input_modifier: InputModifierType = None, ma_type: MAType = MAType.SMA):
super().__init__(input_modifier=input_modifier)

self.period = period
self.volume_div = volume_div
Expand Down
6 changes: 3 additions & 3 deletions talipp/indicators/ForceIndex.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import List, Any

from talipp.indicator_util import has_valid_values
from talipp.indicators.Indicator import Indicator, ValueExtractorType
from talipp.indicators.Indicator import Indicator, InputModifierType
from talipp.ma import MAFactory, MAType
from talipp.ohlcv import OHLCV

Expand All @@ -14,8 +14,8 @@ class ForceIndex(Indicator):
"""

def __init__(self, period: int, input_values: List[OHLCV] = None, input_indicator: Indicator = None,
value_extractor: ValueExtractorType = None, ma_type: MAType = MAType.EMA):
super().__init__(value_extractor = value_extractor)
input_modifier: InputModifierType = None, ma_type: MAType = MAType.EMA):
super().__init__(input_modifier=input_modifier)

self.ma = MAFactory.get_ma(ma_type, period)
self.add_managed_sequence(self.ma)
Expand Down
Loading

0 comments on commit 3991e1b

Please sign in to comment.