Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setup CI/CD #66

Merged
merged 11 commits into from
Mar 1, 2024
Merged

feat: setup CI/CD #66

merged 11 commits into from
Mar 1, 2024

Conversation

jc-tung
Copy link
Collaborator

@jc-tung jc-tung commented Feb 29, 2024

Closes #41

nareha
nareha reviewed Feb 29, 2024
View reviewed changes
Copy link
Owner

@nareha nareha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this bit of nitpick-y code format request: could you add an empty line at the end of the files?

@nareha
Copy link
Owner

nareha commented Feb 29, 2024

Also, if we want to fix the current build failures, this might be helpful?

@jc-tung
Copy link
Collaborator Author

jc-tung commented Feb 29, 2024

Also, if we want to fix the current build failures, this might be helpful?

Thanks for the suggestion! I did the formatting thing too.

nareha
nareha approved these changes Feb 29, 2024
View reviewed changes
Copy link
Owner

@nareha nareha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for handling this setup!

@jc-tung
fix: remove version 14.x from node-version
02c43da 
- react-scripts test is incompatible w/ node.js 14.x, need version 16.x+
@jc-tung
Copy link
Collaborator Author

jc-tung commented Mar 1, 2024

FYI, I removed version 14.x from the yaml file b/c its incompatible with react-scripts test.

facebook/create-react-app#11792

@nareha nareha changed the title CI/CD setup feat: setup CI/CD Mar 1, 2024
@jc-tung jc-tung merged commit 2b3f685 into main Mar 1, 2024
1 check passed
@nareha nareha deleted the CI/CD-Setup branch March 16, 2024 04:07
@nareha nareha restored the CI/CD-Setup branch March 16, 2024 04:08
@nareha nareha deleted the CI/CD-Setup branch March 16, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nareha nareha nareha approved these changes

@steveez123 steveez123 Awaiting requested review from steveez123

@alanhwu alanhwu Awaiting requested review from alanhwu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up CI/CD with Github Actions
2 participants
@jc-tung @nareha