Moving core Action types to Zod schema as source of truth #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcalderipe
reviewed
Mar 27, 2024
Comment on lines
+80
to
+86
| export const ActionSchema = z.nativeEnum(Action) | ||
|
|
||
| export const BaseActionSchema = z.object({ | ||
| action: ActionSchema, | ||
| nonce: z.string() | ||
| }) | ||
| export type BaseActionSchema = z.infer<typeof BaseActionSchema> |
There was a problem hiding this comment.
Please move the schema to their own files like at src/lib/schema like the others.
Also, we're using camelCase plus the schema prefix as the naming convention. For example, from BaseActionSchema to baseActionSchema.
There was a problem hiding this comment.
https://narvalxyz.slack.com/archives/C067Q1TDA9G/p1711552650935279
I'm proposing that we do NOT put schema in their own files, and that we PascalCase lol
BaseActionSchema is a bit of a weird one, I haven't gotten it to map properly to our existing Action const type, so that's why it still has the word schema in the name. The goal is that there is just BaseAction.
mattschoch
force-pushed
the
chore/type-to-zod-refactor
branch
from
a729d3b to
acf4096
Compare
mattschoch
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.