Require client authentication in the evaluation endpoint #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the evaluation to its own controller. Add E2E tests for the evaluation.
mattschoch
reviewed
Mar 27, 2024
Comment on lines
+31
to
+33
| const aliceSignature = await signJwt(payload, secp256k1PrivateKeyToJwk(UNSAFE_PRIVATE_KEY.Alice)) | ||
| const bobSignature = await signJwt(payload, secp256k1PrivateKeyToJwk(UNSAFE_PRIVATE_KEY.Bob)) | ||
| const carolSignature = await signJwt(payload, secp256k1PrivateKeyToJwk(UNSAFE_PRIVATE_KEY.Carol)) |
There was a problem hiding this comment.
did you intentionally remove { alg: SigningAlg.EIP191 } so it's not using EIP191 to sign things now?
There was a problem hiding this comment.
It'll use the JWK alg that in this case is ES256K. Is that wrong?
mattschoch
approved these changes
Mar 27, 2024
wcalderipe
deleted the
feature/require-client-auth-in-the-evaluation-endpoint
branch
mattschoch
pushed a commit
that referenced
this pull request
Jun 19, 2024
* Require client ID in the evaluation endpoint Move the evaluation to its own controller. Add E2E tests for the evaluation. * Require client secret on the evaluation endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.