Overflow sign and validate #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ptroger
force-pushed
the
overflow-sign-and-validate
branch
from
50dff07 to
dd3db61
Compare
mattschoch
reviewed
Apr 1, 2024
Comment on lines
+67
to
+71
| p: z.string().optional(), | ||
| q: z.string().optional(), | ||
| dp: z.string().optional(), | ||
| dq: z.string().optional(), | ||
| qi: z.string().optional() |
There was a problem hiding this comment.
Why'd you make all these optional? They're all required for an RSA key
mattschoch
pushed a commit
that referenced
this pull request
Jun 19, 2024
* validate takes an object for clarity * changed signing interface, normalize usage * formatted after rebase * Test coverage on different signing calls * added tests around top level converters * fix after rebase * format * expose every utils * removed signing service * fix vault CI * use correct interface * removed console.logs * fix test verifying wrong key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.