Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cors config optional + move withCors to shared package #216

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Make cors config optional + move withCors to shared package #216

merged 2 commits into from
Apr 3, 2024

Conversation

samteb
Copy link

@samteb samteb commented Apr 3, 2024

No description provided.

@samteb samteb requested a review from wcalderipe April 3, 2024 14:47
wcalderipe
wcalderipe reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@wcalderipe wcalderipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

You don't need the CORS in the apps/policy-engine/.env.test.default

@samteb samteb merged commit 5fbd2b7 into main Apr 3, 2024
2 checks passed
@samteb samteb deleted the move-with-cors-to-shared-package branch April 3, 2024 14:57
mattschoch pushed a commit that referenced this pull request Jun 19, 2024
Make cors config optional + move withCors to shared package (#216)
c475bee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcalderipe wcalderipe wcalderipe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samteb @wcalderipe