Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed data store to armory app #233

Merged
merged 35 commits into from
May 7, 2024
Merged

Add managed data store to armory app #233

merged 35 commits into from
May 7, 2024

Conversation

samteb
Copy link

@samteb samteb commented Apr 17, 2024

No description provided.

Copy link
Collaborator

@wcalderipe wcalderipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

I left some questions. If you have to prioritize them, please answer the ones about data store entity and policy data model coupling that I left in the schema.prisma file.

packages/policy-engine-shared/src/lib/type/action.type.ts Outdated Show resolved Hide resolved
@samteb samteb requested a review from wcalderipe April 17, 2024 19:54
@samteb samteb changed the title Bootstrap admin service Add admin module to armory app Apr 19, 2024
@samteb samteb requested a review from wcalderipe April 19, 2024 07:54
@samteb samteb requested a review from wcalderipe May 3, 2024 16:23
@samteb samteb changed the title Add admin module to armory app Add managed data store to armory app May 3, 2024
@samteb samteb requested a review from wcalderipe May 6, 2024 13:15
data: hash(FIXTURE.ENTITIES),
sub: 'test-root-user-uid',
iss: 'https://armory.narval.xyz',
iat: Math.floor(new Date('2023-01-01').getTime() / 1000) // in seconds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we always add the iat claim using seconds?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my research seconds are the standard. See this RFC.

Copy link
Collaborator

@wcalderipe wcalderipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 💪

@samteb samteb requested review from mattschoch and wcalderipe May 7, 2024 12:06
@samteb samteb merged commit cb82360 into main May 7, 2024
4 checks passed
@samteb samteb deleted the bootstrap-admin-service branch May 7, 2024 12:11
mattschoch pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants