-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add managed data store to armory app #233
Conversation
…te-the-admin-service
…te-the-admin-service
…te-the-admin-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
I left some questions. If you have to prioritize them, please answer the ones about data store entity and policy data model coupling that I left in the schema.prisma
file.
apps/armory/src/managed-data-store/core/service/entity-data-store.service.ts
Outdated
Show resolved
Hide resolved
apps/armory/src/managed-data-store/core/service/entity-data-store.service.ts
Outdated
Show resolved
Hide resolved
...rsistence/schema/migrations/20240419142843_add_created_at_to_data_store_tables/migration.sql
Outdated
Show resolved
Hide resolved
...ed/module/persistence/schema/migrations/20240417115049_create_data_store_table/migration.sql
Outdated
Show resolved
Hide resolved
apps/armory/src/managed-data-store/core/__test__/unit/signature.service.spec.ts
Outdated
Show resolved
Hide resolved
data: hash(FIXTURE.ENTITIES), | ||
sub: 'test-root-user-uid', | ||
iss: 'https://armory.narval.xyz', | ||
iat: Math.floor(new Date('2023-01-01').getTime() / 1000) // in seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we always add the iat claim using seconds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my research seconds are the standard. See this RFC.
apps/armory/src/managed-data-store/core/service/entity-data-store.service.ts
Outdated
Show resolved
Hide resolved
apps/armory/src/managed-data-store/core/service/entity-data-store.service.ts
Outdated
Show resolved
Hide resolved
apps/armory/src/managed-data-store/core/service/signature.service.ts
Outdated
Show resolved
Hide resolved
apps/armory/src/managed-data-store/managed-data-store.module.ts
Outdated
Show resolved
Hide resolved
apps/armory/src/managed-data-store/persistence/repository/client.repository.ts
Outdated
Show resolved
Hide resolved
apps/armory/src/managed-data-store/persistence/repository/entity-data-store.repository.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 💪
No description provided.