Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Startup (Windows 7) #149

Closed
MiraakThuri opened this issue Oct 4, 2022 · 12 comments
Closed

Crash on Startup (Windows 7) #149

MiraakThuri opened this issue Oct 4, 2022 · 12 comments

Comments

@MiraakThuri
Copy link

Hey, so i just updated from 0.31 (the W7 special version) to 0.4
And now all my games wich were working fine before crash on startup
(AOE1, AVP2, RealMyst)

Tried without custom settings and with custom settings, same result
(i tried to change DisplayResolution=app
DpiAwareness=app
FullscreenMode=exclusive)

DDrawCompat-lithtech.log
here is the log file from avp2, dunno if it might help u

@narzoul
Copy link
Owner

narzoul commented Oct 4, 2022

Please change the LogLevel setting to debug and upload the log with that. Thanks!

@MiraakThuri
Copy link
Author

DDrawCompat-lithtech.log
Here it is with debug mode

@narzoul
Copy link
Owner

narzoul commented Oct 5, 2022

Ok, I think I found the culprit. Please try this test version:
ddraw.zip (diff.txt compared to v0.4.0)

@MiraakThuri
Copy link
Author

MiraakThuri commented Oct 6, 2022

Ok, so RealMyst is working now but AOE1 and AVP2 are still crashing, but not at the same time
before it would crash instantly, now the screen turn black 1 sec, like the game would start normally, then it crash
DDrawCompat-lithtech.log

(also tried without my custom settings, same result)

@narzoul
Copy link
Owner

narzoul commented Oct 6, 2022

Hmm, it seems to crash in SetCursor, but I'm not sure what could crash there. Could you please collect a crash dump also? I have some instructions here: #50 (comment)
Please also attach the new debug logs again with the crash dump.

@MiraakThuri
Copy link
Author

@narzoul
Copy link
Owner

narzoul commented Oct 7, 2022

Thanks! Unfortunately, the crash dump seems to get created after the original exception, so I still don't see what exactly is causing it. But at least I noticed an extra dinput.dll in your game directory. Where is that from? It might be installing some hooks that interferes with DDrawCompat. Can you try running the game without it?

@MiraakThuri
Copy link
Author

It's a wrapper to convert dinput to dinput8 (that game has some mouse issues) but i still get the crash without it
And AOE1 don't have any additional wrappers, ill send you the log and dump from that game this time, maybe it will give better infos
DDrawCompat-Empires.log
Empires.exe.6056.dmp.zip

@narzoul
Copy link
Owner

narzoul commented Oct 7, 2022

It looks the same. I found the issue anyway. The GetCursor function has an early call instruction with relative addressing on Windows 7, which wasn't patched up when moving it to the trampoline during hooking. This should fix it:
ddraw.zip (diff.txt compared to v0.4.0)

@MiraakThuri
Copy link
Author

Yes it working just fine now
Thx for your time on this

@narzoul
Copy link
Owner

narzoul commented Oct 7, 2022

Great, thanks for the reports! I'll add the fixes to the next release.

@narzoul
Copy link
Owner

narzoul commented Nov 13, 2023

Win 7 startup crashes have been fixed in v0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants