Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Point display filtering not working #252

Closed
OpenRift412 opened this issue Nov 13, 2023 · 4 comments
Closed

[Bug] Point display filtering not working #252

OpenRift412 opened this issue Nov 13, 2023 · 4 comments

Comments

@OpenRift412
Copy link

Was testing out the new release and found that the point option for display filtering doesn't seem to be working at all. It seems to just be using whatever the default is.

@narzoul
Copy link
Owner

narzoul commented Nov 13, 2023

You're right, I must have broken it with one of the recent changes before release. I also forgot to document that downscaling was changed to use convolution for all existing filters too, which means it would apply a box filter for the "point" option.

Well, luckily this isn't the most important filter, but I'll try to fix it.

@OpenRift412
Copy link
Author

Well, luckily this isn't the most important filter, but I'll try to fix it.

I would argue otherwise, but that's ultimately up to you.

@narzoul
Copy link
Owner

narzoul commented Nov 13, 2023

It seems to have been a simple issue, here's a quick fix until the next release:
ddraw.zip (diff.txt compared to v0.5.0)

narzoul added a commit that referenced this issue Nov 17, 2023
@narzoul
Copy link
Owner

narzoul commented Nov 17, 2023

Fixed in v0.5.1.

@narzoul narzoul closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants