-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating npm to 16.20.2 #427
Conversation
Noting a dependency issue that I'll look into Monday:
|
Now fixed. |
My comment markup is confusing, but what I intended to suggest was that another approach we took could be to just widen the compatibility instead of upgrading explorer-1: "node": "^14.19.0",
"npm": "^6.14.16" Note the addition of the carets rather than bumping version numbers. I'm pro-upgrading but the suggestion above would be less disruptive for other projects that use explorer-1. |
Dev page and Storybook are both working fine. While testing, I noticed that Placekitten has run out of lives 😿 so I standardized all of our placeholder images to use https://picsum.photos. One thing I noticed is that after building for Storybook, the built CSS and JS had some minor changes. Think we should go ahead and include those?
I agree we should press on. 16 is already EOL, too, so this should just be considered a stepping stone to 18 and 20. As far as we know, our projects are the only ones that consume explorer-1, right? I don't feel bad about forcing our own projects to upgrade if they want to upgrade explorer-1. |
Thanks @Scotchester, I've updated the build files. |
Checklist
Description
@tailwindcss/forms
to 0.3.4 as the compatibility has changed (0.4.0+ requires Tailwind 3: https://github.com/tailwindlabs/tailwindcss-forms/releases?page=2)Instructions to test
Tested in the following environments/browsers:
Operating System
Browser