Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Storybook 8.1.1, fixing some docs display issues #431

Merged
merged 4 commits into from
May 15, 2024

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Updates to the latest version of Storybook, and fixes typeface in the Storybook docs.

Also adds a makefile for common storybook npx commands.

Instructions to test

  1. npm run storybook

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle requested a review from jamesray May 15, 2024 18:00
@github-actions github-actions bot added bug Something isn't working maintenance The meta work of maintaining the project storybook This issue relates to Storybook.js labels May 15, 2024
@stephiescastle stephiescastle removed the bug Something isn't working label May 15, 2024
@stephiescastle stephiescastle enabled auto-merge (squash) May 15, 2024 18:22
@stephiescastle stephiescastle merged commit 797d29d into main May 15, 2024
1 check passed
@stephiescastle stephiescastle deleted the chore/upgrade-sb-8.1.1 branch May 15, 2024 18:22
@stephiescastle stephiescastle added the patch Contains bug fixes or maintenance work label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project patch Contains bug fixes or maintenance work storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants