Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React App Integration/Demo #4

Merged
merged 2 commits into from
Sep 6, 2023
Merged

React App Integration/Demo #4

merged 2 commits into from
Sep 6, 2023

Conversation

fahnestockj
Copy link
Collaborator

  • Added the React App's repository as a git submodule
  • Added React build step to github actions (didn't have a good way to test this so may need a tweak)
    • React builds the javascript and css files to hugo's static folder
  • Modified About section to include a hugo shortcode pointing to the react build in the static folder

@betolink
Copy link
Member

betolink commented Sep 6, 2023

@fahnestockj should we merge this now that we know that it works on Github pages?

@fahnestockj
Copy link
Collaborator Author

fahnestockj commented Sep 6, 2023

@betolink I'm concerned the same errors from this morning will happen? Has something changed since then? If so totally!

@betolink betolink merged commit 3ed2962 into main Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants