fix: path to head assembly 3d parts #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethfischer
force-pushed
the
fix-head-3d-parts-link
branch
3 times, most recently
from
1f14e31 to
e74e0bd
Compare
Achllle
reviewed
Jul 2, 2021
mechanical/head_assembly/README.md
Outdated
| @@ -42,7 +42,7 @@ The head assembly serves as the head and face of our rover. It houses a 16x32 fu | |||
|
|
|||
|
|
|||
| ## 3. 3D Printing | |||
| There are a few components that need to be 3D printed to make the head assembly. You can find the STL files necessary for these prints in the ”Mechanical/Head Assembly/3D Printed Parts” folder of the repository. | |||
| There are a few components that need to be 3D printed to make the head assembly. You can find the STL files necessary for these prints in the [mechanical/head_assembly/3d_printed_parts](https://github.com/nasa-jpl/open-source-rover/tree/master/mechanical/head_assembly/3d_printed_parts) folder of the repository. | |||
There was a problem hiding this comment.
Suggested change
| There are a few components that need to be 3D printed to make the head assembly. You can find the STL files necessary for these prints in the [mechanical/head_assembly/3d_printed_parts](https://github.com/nasa-jpl/open-source-rover/tree/master/mechanical/head_assembly/3d_printed_parts) folder of the repository. | |
| There are a few components that need to be 3D printed to make the head assembly. You can find the STL files necessary for these prints in the [mechanical/head_assembly/3d_printed_parts](3d_printed_parts) folder of the repository. |
Relative link should work as well
There was a problem hiding this comment.
@Achllle Link updated
sethfischer
force-pushed
the
fix-head-3d-parts-link
branch
from
e74e0bd to
d62c5f1
Compare
Fix path to head Head Assembly 3D parts and make the path a link.
sethfischer
force-pushed
the
fix-head-3d-parts-link
branch
from
d62c5f1 to
5073456
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix path to head Head Assembly 3D parts and make the path a link.