Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing extra parts into V2 Partslist #405

Merged
merged 15 commits into from
Jul 30, 2023
Merged

Added missing extra parts into V2 Partslist #405

merged 15 commits into from
Jul 30, 2023

Conversation

BaeHenryS
Copy link
Contributor

No description provided.

Achllle
Achllle requested changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BaeHenryS. This is not documented anywhere yet but the parts list README shouldn't be updated directly because it is autogenerated through csv_to_md.py. You either add the parts to the gobilda or digikey csv files or add them to the extra_parts.md file which gets appended to the main README. We should probably have a different file for some of the items like the DROK but for now you can cut and paste them over to the extra_parts.md file.

Once that's done, you can either run the csv_to_md.py file yourself but that isn't required because there's a Github action that runs that file and opens a PR or adds a commit to run the script.

parts_list/README.md Outdated Show resolved Hide resolved
BaeHenryS added 2 commits July 27, 2023 18:20
@BaeHenryS
Changed Extra_parts.md
1e7136d 
Added the parts to extra_parts.md instead and also documented quick instruction on adding/replacing parts
@BaeHenryS
Removed Drive Motor Connector
aa31ed2
BaeHenryS
BaeHenryS commented Jul 28, 2023
View reviewed changes
Copy link
Contributor Author

@BaeHenryS BaeHenryS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Also added instructions for future people to change parts.

parts_list/README.md Outdated Show resolved Hide resolved
@BaeHenryS @Achllle
Update parts_list/README.md
e1666d2 
Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
Achllle
Achllle reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor spacing comments, then should be good to go!

Avoid committing the parts_list/README file since the action will run it and it clutters the PR

parts_list/README.md Outdated
Comment on lines 250 to 251


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Didn't mean to, accidentally committed on the README.md suggestion

parts_list/extra_parts.md Outdated Show resolved Hide resolved
parts_list/extra_parts.md Outdated Show resolved Hide resolved
parts_list/extra_parts.md Outdated Show resolved Hide resolved
parts_list/extra_parts.md Outdated Show resolved Hide resolved
BaeHenryS and others added 8 commits July 27, 2023 20:59
@BaeHenryS @Achllle
Update parts_list/extra_parts.md
f3a1490 
Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
@BaeHenryS @Achllle
Update parts_list/extra_parts.md
b018fb4 
spacing

Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
@BaeHenryS @Achllle
Update parts_list/extra_parts.md
9b94578 
Spacing

Co-authored-by: Achille Verheye <achille.verheye@gmail.com>
@BaeHenryS
Removed wire link for now
8829a77
@BaeHenryS
Merge branch 'v2' of https://github.com/BaeHenryS/open-source-rover i…
4724958 
…nto v2
@BaeHenryS
Revert "Merge branch 'v2' of https://github.com/BaeHenryS/open-source…
4964627 
…-rover into v2"

This reverts commit 4724958, reversing
changes made to 8829a77.
@BaeHenryS
Revert "Removed wire link for now"
78860a7 
This reverts commit 8829a77.
@BaeHenryS
Removed Wire Links for Now
b6aed49
@Achllle
Copy link
Collaborator

Achllle commented Jul 28, 2023

It seems like you didn't commit my suggestions. The idea is to remove the extra spacing everywhere as well as the horizontal lines which we don't have elsewhere.

@BaeHenryS
Copy link
Contributor Author

Ah, I committed but seems like I messed up after editing other parts. I have made all the spacing changes!

Achllle
Achllle reviewed Jul 30, 2023
View reviewed changes
parts_list/extra_parts.md Outdated Show resolved Hide resolved
Achllle
Achllle approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@Achllle Achllle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looking forward to more :)

@Achllle Achllle merged commit 475c24e into nasa-jpl:v2 Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Achllle Achllle Achllle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BaeHenryS @Achllle