Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFDP protocol timer configuration is not per channel (CF5002 and CF4000.1.1 failure) #120

Closed
semaldona opened this issue Dec 13, 2021 · 3 comments · Fixed by #257
Closed
Assignees
Milestone

Comments

@semaldona
Copy link

Per requirement CF5002, protocol timer configuration should be per channel. Currently the values are applied to all channels.

@astrogeco astrogeco added this to the Draco milestone May 11, 2022
@skliper skliper added bug and removed requirements labels May 20, 2022
@skliper
Copy link
Contributor

skliper commented May 20, 2022

None of these are by channel, although the requirements also have issues since 1 and 4 are duplicates. Either way, these likely should really be per channel since some could be local and others quite far away so changing this to a bug.

CF5002,CF5002,"The following parameters shall be configurable by a CF command:

  1. CFDP channel Ack-Timer Value (seconds)
  2. CFDP channel NAK-Timer Value (seconds)
  3. CFDP channel Inactivity-Timeout Value (seconds)
  4. CFDP channel Ack-Timer Value (seconds)
  5. CFDP channel Maximum Ack Timeouts (integer counts)
  6. CFDP channel Maximum NAK Timeouts (integer counts)","Operational interface to support mission variability and reconfiguration"

CF5002.1,CF5002.1,"The default values for the CFDP channel protocol parameters below shall be defined by a CF Configuration Table:

  1. CFDP channel Ack-Timer Value (seconds)
  2. CFDP channel NAK-Timer Value (seconds)
  3. CFDP channel Inactivity-Timeout Value (seconds)
  4. CFDP channel Ack-Timer Value (seconds)
  5. CFDP channel Maximum Ack Timeouts (integer counts)
  6. CFDP channel Maximum NAK Timeouts (integer counts)",Ensure CF starts in a known and valid operational state

@skliper skliper changed the title CFDP protocol timer configuration is not per channel CFDP protocol timer configuration is not per channel (CF5002 and CF4001.1.1 failure) May 24, 2022
@skliper
Copy link
Contributor

skliper commented May 24, 2022

Note with update in #248, this also fails CF4000.1.1

@skliper
Copy link
Contributor

skliper commented May 24, 2022

Note duplicated element in requirement is addressed in #248, so just the bug remains to resolve.

@skliper skliper changed the title CFDP protocol timer configuration is not per channel (CF5002 and CF4001.1.1 failure) CFDP protocol timer configuration is not per channel (CF5002 and CF4000.1.1 failure) Jun 7, 2022
@skliper skliper self-assigned this Jun 7, 2022
skliper added a commit to skliper/CF that referenced this issue Jun 7, 2022
astrogeco added a commit that referenced this issue Jun 8, 2022
Fix #120 #256, Move timers into channel config and remove cfg telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants