Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default configuration to not use throttling semaphore #178

Closed
jphickey opened this issue Jan 13, 2022 · 0 comments · Fixed by #180
Closed

Change default configuration to not use throttling semaphore #178

jphickey opened this issue Jan 13, 2022 · 0 comments · Fixed by #180

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The default/example table source files include a semaphore name - cf_1_sem and cf_2_sem - for throttling on channel 1 and 2, respectively.

However, CF does not actually create the throttling semaphores, it expects the semaphore to be created before CF starts. If a new user is starting CF by itself with no other support apps running, this semaphore will not exist.

Describe the solution you'd like
To make it simpler to build and run CF with a default configuration, the example table should have an empty string for the semaphore name - this means no throttle.

Additional context
This will make CF at least boot up and load "out of the box" ... but probably any real deployment will need a throttle, so this means that we don't have an example of a throttling semaphore anymore.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/CF that referenced this issue Jan 13, 2022
Unless something actually instantiates this semaphore, this
prevents CF from initializing correctly.

With this, at least CF should start up with the out-of-box config.
astrogeco added a commit that referenced this issue Jan 13, 2022
Fix #178, remove throttle sem from default/example config
@skliper skliper added this to the Draco milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants