Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering 100+ event filters w/ 0x0000 values serves no purpose (and overflows a typical filter buffer) #260

Closed
3 tasks done
skliper opened this issue Jun 14, 2022 · 0 comments · Fixed by #261
Closed
3 tasks done

Comments

@skliper
Copy link
Contributor

skliper commented Jun 14, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Registering event filters just to register event filters doesn't do anything but load the system. If an event needs to be filtered operationally, just use the add filter command. Note default CFE_PLATFORM_EVS_MAX_EVENT_FILTERS is 8, so the rest would get discarded and cause a filter buffer overflow event.

Describe the solution you'd like
Remove filter registration for those set to 0x0000 (all of them!) Add operationally if/when needed, or if eventually an actual filter needs to be applied then add it.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone Jun 14, 2022
skliper added a commit to skliper/CF that referenced this issue Jun 14, 2022
astrogeco added a commit that referenced this issue Jun 16, 2022
Fix #260, Remove registration of empty EVS filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant