-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event ID name doesn't match use #262
Comments
Maybe Having said that, there is a large variance in formats and order-of-components in names for similar events in other components/apps, so getting to a consistent format at some point in the future would make things easier. At a glance, there is: |
ping @havencarlson @skliper |
ping @dmknutsen @dzbaker - they are the deciderers now :) |
Seems very reasonable to go with the most common format - CF_MID_ERR_EID looks good to me... |
Fix #262, Update inaccurate event ID name
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
CF_EID_ERR_INIT_CMD_LENGTH
is used for reporting invalid MID received, noteCF_EID_ERR_CMD_GCMD_LEN
andCF_EID_ERR_CMD_GCMD_CC
are used for actual ground command processing:CF/fsw/src/cf_app.c
Lines 321 to 322 in 593d61a
Describe the solution you'd like
Event ID names should make sense, maybe
CF_EID_ERR_MID
or similar.Describe alternatives you've considered
None
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: