We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist (Please check before submitting)
Describe the bug Passing 192 (for default OS_MAX_PATH_LEN of 64) instead of 180 due to use of SB buffer size instead of packet size.
CF/fsw/src/cf_cfdp.c
Lines 1706 to 1715 in 5df892e
CF/fsw/inc/cf_msg.h
Lines 156 to 160 in 5df892e
To Reproduce Can confirm from a cmd/tlm server or inline: sizeof(CF_EotPktBuf_t) is 192 sizeof(CF_EotPacket_t) is 180
Expected behavior Pass in the actual packet size, not the SB buffer size which has the most strict alignment/rounding requirements.
Code snips See above
System observed on:
Additional context None
Reporter Info Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
Fix nasa#406, Pass in correct CF_EotPacket_t size to msg
df8d23b
Merge pull request #407 from skliper/fix406-eot_pkt_size_bug
196574d
Fix #406, Pass in correct CF_EotPacket_t size to msg
skliper
chillfig
Successfully merging a pull request may close this issue.
Checklist (Please check before submitting)
Describe the bug
Passing 192 (for default OS_MAX_PATH_LEN of 64) instead of 180 due to use of SB buffer size instead of packet size.
CF/fsw/src/cf_cfdp.c
Lines 1706 to 1715 in 5df892e
CF/fsw/inc/cf_msg.h
Lines 156 to 160 in 5df892e
To Reproduce
Can confirm from a cmd/tlm server or inline:
sizeof(CF_EotPktBuf_t) is 192
sizeof(CF_EotPacket_t) is 180
Expected behavior
Pass in the actual packet size, not the SB buffer size which has the most strict alignment/rounding requirements.
Code snips
See above
System observed on:
Additional context
None
Reporter Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: