Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cf delete file when there is an error during tx #441

Closed
1 task done
avan989 opened this issue May 15, 2024 · 1 comment · Fixed by #459
Closed
1 task done

cf delete file when there is an error during tx #441

avan989 opened this issue May 15, 2024 · 1 comment · Fixed by #459

Comments

@avan989
Copy link

avan989 commented May 15, 2024

Checklist (Please check before submitting)

  • [x ] I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CF deletes the file even when there is an error during the TX.

To Reproduce
Steps to reproduce the behavior:

  1. Send an tx command/put file in polling directory with small "time-out" in config
  2. Error Message that file.
  3. File gets deleted.

Expected behavior
A clear and concise description of what you expected to happen.
If there is an error, the file should not be deleted.

Code snips
If applicable, add references to the software.

System observed on:

  • Hardware
  • OS: [e.g. Linux 4.4]
  • Versions [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps]

Additional context
Add any other context about the problem here.

Reporter Info
Full name and company/organization if applicable

Anh Van, GSFC
@avan989 avan989 changed the title cf delete files when there is an error during tx cf delete file when there is an error during tx May 15, 2024
@skliper
Copy link
Contributor

skliper commented May 15, 2024 •
edited
Loading

Might want to handle the case where the file is in the polling directory differently, since if there's an error you could get into an endless loop of attempting to send the file over and over again. Maybe move the file to a "failed" directory?

avan989 pushed a commit to avan989/CF that referenced this issue May 16, 2024
Fix nasa#441, cf delete files during error when tx
56e6d91 
Fix nasa#441, Update to handle error during tx.
1. For polling, the file gets moved or deleted to pervent infinite loop
2. For others, the file does not get deleted.
avan989 pushed a commit to avan989/CF that referenced this issue May 16, 2024
Fix nasa#441, cf delete files during error when tx
887843e 
Fix nasa#441, Update to handle error during tx.
1. For polling, the file gets moved or deleted to pervent infinite loop
2. For others, the file does not get deleted.
avan989 pushed a commit to avan989/CF that referenced this issue May 16, 2024
Fix nasa#441, cf delete files during error when tx
9fafd0f 
Fix nasa#441, Update to handle error during tx.
1. For polling, the file gets moved or deleted to pervent infinite loop
2. For others, the file does not get deleted.
@avan989 avan989 mentioned this issue May 16, 2024
Closed
avan989 pushed a commit to avan989/CF that referenced this issue May 17, 2024
Fix nasa#441, cf delete files during error when tx
e187427 
Fix nasa#441, Update to handle error during tx.
1. For polling, the file gets moved or deleted to pervent infinite loop
2. For others, the file does not get deleted.
avan989 pushed a commit to avan989/CF that referenced this issue Jul 31, 2024
Fix nasa#441, cf delete files during error when tx
a26a8e9 
Fix nasa#441, Update to handle error during tx. For polling, the file gets moved or deleted to pervent infinite loop. For others, the file does not get deleted.
avan989 pushed a commit to avan989/CF that referenced this issue Aug 1, 2024
Fix nasa#441, cf delete files during error when tx
1441e5d 
Fix nasa#441, Update to handle error during tx. For polling, the file gets moved or deleted to pervent infinite loop. For others, the file does not get deleted. Update Unit Test.
@avan989 avan989 mentioned this issue Aug 1, 2024
Merged
2 tasks
avan989 pushed a commit to avan989/CF that referenced this issue Aug 1, 2024
Fix nasa#441, cf delete files during error when tx
b357f17 
Fix nasa#441, Update to handle error during tx. For polling, the file gets moved or deleted to pervent infinite loop. For others, the file does not get deleted. Update Unit Test and documentation.
dzbaker added a commit that referenced this issue Aug 8, 2024
@dzbaker
Merge pull request #459 from avan989/Fix-441-cf-delete-file-transmit-…
7eac600 
…error

Fix #441, cf delete files during error when tx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@avan989 @skliper