Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #111, make dispatch tables and functions consistent #135

Merged
merged 1 commit into from
Dec 17, 2021

Commits on Dec 17, 2021

  1. Fix nasa#111, make dispatch tables and functions consistent

    Standardize the dynamic handler functions to two basic types,
    one that accepts a PDU (recv) and one that does not (send).
    
    Also create several dispatch table types, one based on
    file directive code, one based on Tx sub state, and one based
    on Rx sub state.
    
    Change the dispatcher functions to use these common types
    and create new dispatcher functions where there was not
    a separate function already (this makes the pattern consistent).
    
    Make all "receive" helper functions accept a pointer to the
    recieved PDU and actually use that pointer to read the data.  This
    substantially reduces reliance on the global and fixes some
    cases where a pointer was actually passed into a function, but
    ignored.  This takes a significant step toward removing the
    global entirely, but does not do so yet.
    jphickey committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    132addc View commit details
    Browse the repository at this point in the history