Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #338, Move 'EID' to the end of Event ID names #339

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 22, 2022

Checklist

Describe the contribution

Testing performed
Github Actions (Build/Run + Unit tests) passing successfully.

Expected behavior changes
No impact on behavior (no logic changes).
The format of CF Event IDs is now aligned with the rest of the cFS components/apps, improving code consistency.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker self-assigned this Oct 27, 2022
@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@chillfig
Copy link
Contributor

chillfig commented Mar 9, 2023

CCB:2023.03.09: Putting on hold until naming conventions for event, etc are merged.

@thnkslprpt thnkslprpt force-pushed the fix-338-move-eid-to-end-of-event-id-names branch 4 times, most recently from 8fb2054 to 7c53410 Compare March 12, 2023 20:24
@thnkslprpt thnkslprpt force-pushed the fix-338-move-eid-to-end-of-event-id-names branch 2 times, most recently from 4db3179 to 656df66 Compare April 7, 2023 00:52
@thnkslprpt thnkslprpt force-pushed the fix-338-move-eid-to-end-of-event-id-names branch from 656df66 to 73c0f57 Compare April 17, 2023 23:26
@thnkslprpt thnkslprpt force-pushed the fix-338-move-eid-to-end-of-event-id-names branch from 73c0f57 to 5a32ce0 Compare May 19, 2023 01:41
@thnkslprpt thnkslprpt force-pushed the fix-338-move-eid-to-end-of-event-id-names branch 4 times, most recently from 5a32ce0 to 9773595 Compare August 19, 2023 06:29
@dzbaker
Copy link
Contributor

dzbaker commented Jul 5, 2024

Thanks @thnkslprpt for making these fixes! Apologies about the very long delay in merging these changes; I'd like to get your event ID updates into the next round. Would you be able to resolve the merge conflicts?

@dzbaker dzbaker added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 5, 2024
@thnkslprpt thnkslprpt force-pushed the fix-338-move-eid-to-end-of-event-id-names branch 2 times, most recently from 1388d07 to bf1c619 Compare July 9, 2024 07:36
@thnkslprpt thnkslprpt force-pushed the fix-338-move-eid-to-end-of-event-id-names branch from bf1c619 to f96b59f Compare July 9, 2024 07:42
@thnkslprpt
Copy link
Contributor Author

Thanks @thnkslprpt for making these fixes! Apologies about the very long delay in merging these changes; I'd like to get your event ID updates into the next round. Would you be able to resolve the merge conflicts?

@dzbaker no worries at all Dylan.
That should be updated now.

@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jul 15, 2024
@dzbaker dzbaker merged commit 86e5136 into nasa:main Jul 15, 2024
16 checks passed
@thnkslprpt thnkslprpt deleted the fix-338-move-eid-to-end-of-event-id-names branch July 16, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'EID' should be at the end of the Event ID names
3 participants