Fix #382, Align CF Command Counter implementation to cFS standard #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
cmd
renamed toCommandCounter
err
renamed toCommandErrorCounter
hk
renamed toHkPacket
(most cFS components/apps use this common name for the housekeeping packet)Note: if the
CamelCase
is an issue, can still implement these changes assnake_case
, although I guess now is as good a time as any to start converting CF variables toCamelCase
. If so I can open a new issue to flag that all variables should be changed over - all at once (if someone wants to implement that) or gradually as changes are made.CF is the only cFS app/component to use
snake_case
for naming variables.Re-introduced from #383.#394, #397 reverted this PR.
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit Tests etc.).
Expected behavior changes
Command
/CommandError
counters now held directly in the HK packet, instead of through an additional struct member.This PR improves consistency across cFS, and makes future maintenance easier as variables are named and located as expected.
Contributor Info
Avi Weiss @thnkslprpt