We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE_ES_RunStatus_SYS_EXCEPTION
NULL
bufptr
Checklist
Describe the bug There are a couple of minor sections of dead/unnecessary code in CS.
Code snips
bufptr cannot be NULL (this is guaranteed by CFE_SB_ReceiveBuffer if the return value is CFE_SUCCESS):
CFE_SB_ReceiveBuffer
CFE_SUCCESS
CS/fsw/src/cs_app.c
Lines 86 to 91 in f958cc0
Apparently code was removed that set the run status to CFE_ES_RunStatus_SYS_EXCEPTION, but this check was left in:
Line 119 in f958cc0
Expected behavior Remove dead code to reduce unnecessary clutter.
Reporter Info Avi Weiss @thnkslprpt
The text was updated successfully, but these errors were encountered:
Fix nasa#97, Remove dead code checking for NULL bufptr and RunStatus_…
5759037
…SYS_EXCEPTION
RunStatus_SYS_EXCEPTION
Successfully merging a pull request may close this issue.
Checklist
Describe the bug
There are a couple of minor sections of dead/unnecessary code in CS.
Code snips
bufptr
cannot beNULL
(this is guaranteed byCFE_SB_ReceiveBuffer
if the return value isCFE_SUCCESS
):CS/fsw/src/cs_app.c
Lines 86 to 91 in f958cc0
Apparently code was removed that set the run status to
CFE_ES_RunStatus_SYS_EXCEPTION
, but this check was left in:CS/fsw/src/cs_app.c
Line 119 in f958cc0
Expected behavior
Remove dead code to reduce unnecessary clutter.
Reporter Info
Avi Weiss @thnkslprpt
The text was updated successfully, but these errors were encountered: