-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #82, Convert integers holding boolean truth values to bool
#83
Fix #82, Convert integers holding boolean truth values to bool
#83
Conversation
3d8269d
to
f28181d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be sure that we don't change the tables or command message formats with this
f28181d
to
aa585b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need to revert the changes to "cs_tbldefs.h" .... Everything in this struct should be based on known-width types only - no "bool" or "cpuaddr". So there were prexisting problems there. But the proposed change will alter alignment and still uses bool and cpuaddr.
The change to "cs_compute.c" is good though.
aa585b7
to
cabac30
Compare
@jphickey No worries - I removed the changes to |
Checklist
Describe the contribution
bool
#82bool
Testing performed
GitHub CI actions all passing successfully.
Expected behavior changes
No change to behavior.
Contributor Info
Avi Weiss @thnkslprpt