Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All CMD/TLM message should put content in a "Payload" sub-structure #92

Closed
3 tasks done
jphickey opened this issue Mar 17, 2023 · 0 comments · Fixed by #102
Closed
3 tasks done

All CMD/TLM message should put content in a "Payload" sub-structure #92

jphickey opened this issue Mar 17, 2023 · 0 comments · Fixed by #102
Assignees
@jphickey
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
To match the patterns used in CFE and other modules, all CMD/TLM message definitions should put the content (non-header) parts into a separate struct called "Payload".

Describe the solution you'd like
Separate message content into a sub structure called "Payload".

Additional context
This is benefit to tooling that can use the presence of this field to identify where the actual content starts (e.g. something like offsetof(MsgType, Payload) would work and be correct, as opposed to checking sizeof(CFE_MSG_CommandHeader_t) which may not actually reflect where the content starts due to possible compiler-added padding between them).

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Mar 17, 2023
jphickey added a commit to jphickey/DS that referenced this issue Mar 22, 2023
@jphickey
Fix nasa#92, Use payload sub-struct in all messages
17f308d 
Puts the CMD/TLM content in a member struct called "Payload".  This
makes it consistent with other CFE modules and provides a predictably
named member for determining the position of non-header content.
@jphickey jphickey mentioned this issue Mar 27, 2023
Merged
2 tasks
jphickey added a commit to jphickey/DS that referenced this issue Mar 31, 2023
@jphickey
Fix nasa#92, update documentation references
c173bd3
dzbaker added a commit that referenced this issue Mar 31, 2023
@dzbaker
Merge pull request #102 from jphickey/fix-92-use-payload
15035a8 
Fix #92, Use payload sub-struct in all messages
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #92, Use payload sub-struct in all messages jphickey/DS
3 participants
@jphickey @dmknutsen @chillfig