Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables declared mid-function in test code #102

Closed
2 tasks done
thnkslprpt opened this issue Apr 30, 2023 · 0 comments · Fixed by #103
Closed
2 tasks done

Variables declared mid-function in test code #102

thnkslprpt opened this issue Apr 30, 2023 · 0 comments · Fixed by #103
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
A few cases of variables declared mid-function in the test code.

Expected behavior
All variables should be declared at the top of the function - eases future maintenance and improves consistency.

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Apr 30, 2023
@thnkslprpt
Fix nasa#102, Move variables declared mid-function to the top
bd5abf5
@thnkslprpt thnkslprpt mentioned this issue Apr 30, 2023
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue May 5, 2023
@thnkslprpt
Fix nasa#102, Move variables declared mid-function to the top
3ac92f5
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue May 5, 2023
@thnkslprpt
Fix nasa#102, Move variables declared mid-function to the top
00ddb8a
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue May 18, 2023
@thnkslprpt
Fix nasa#102, Move variables declared mid-function to the top
15b99e7
dzbaker added a commit that referenced this issue May 18, 2023
@dzbaker
Merge pull request #103 from thnkslprpt/fix-102-move-variables-declar…
e7afedc 
…ed-mid-function

Fix #102, Move variables declared mid-function to the top
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #102, Move variables declared mid-function to the top thnkslprpt/FM
3 participants
@thnkslprpt @dmknutsen @chillfig