Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninitialized FileStats in FM_GetVolumeFreeSpace #109

Closed
2 tasks done
skliper opened this issue Jul 17, 2023 · 0 comments · Fixed by #110
Closed
2 tasks done

Uninitialized FileStats in FM_GetVolumeFreeSpace #109

skliper opened this issue Jul 17, 2023 · 0 comments · Fixed by #110
Assignees
@skliper
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@skliper
Copy link
Contributor

skliper commented Jul 17, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Uninitialized variable warning in CodeSonar:

FM/fsw/src/fm_cmd_utils.c

Line 536 in 98283b6

OS_statvfs_t FileStats;

from:

FM/fsw/src/fm_cmd_utils.c

Line 541 in 98283b6

OS_Status = OS_FileSysStatVolume(FileSys, &FileStats);

To Reproduce
Run static analysis

Expected behavior
No uninitialized variable warnings

System observed on:
Static analysis

Additional context
None

Reporter Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the Equuleus milestone Jul 17, 2023
@skliper skliper self-assigned this Jul 17, 2023
skliper added a commit to skliper/FM that referenced this issue Jul 17, 2023
@skliper
Fix nasa#109, Uninitialized FileStats in FM_GetVolumeFreeSpace
eb8c99e
@skliper skliper mentioned this issue Jul 17, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Aug 31, 2023
@dzbaker
Merge pull request #110 from skliper/fix109-uninit_filestats
4c8c383 
Fix #109, Uninitialized FileStats in FM_GetVolumeFreeSpace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #109, Uninitialized FileStats in FM_GetVolumeFreeSpace skliper/FM
2 participants
@skliper @chillfig