Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8, remove return statements from void functions #47

Merged
merged 1 commit into from
Aug 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions fsw/src/fm_app.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,6 @@ void FM_ProcessPkt(const CFE_SB_Buffer_t *BufPtr)
break;
}

return;

} /* End of FM_ProcessPkt */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -388,8 +386,6 @@ void FM_ProcessCmd(const CFE_SB_Buffer_t *BufPtr)
FM_GlobalData.CommandErrCounter++;
}

return;

} // End of FM_ProcessCmd

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -436,8 +432,6 @@ void FM_ReportHK(const CFE_MSG_CommandHeader_t *Msg)
CFE_SB_TransmitMsg(&FM_GlobalData.HousekeepingPkt.TlmHeader.Msg, true);
}

return;

} // End of FM_ReportHK

/************************/
Expand Down
33 changes: 0 additions & 33 deletions fsw/src/fm_child.c
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ void FM_ChildTask(void)
/* This call allows cFE to clean-up system resources */
CFE_ES_ExitChildTask();

return;

} /* End of FM_ChildTask() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -192,8 +190,6 @@ void FM_ChildLoop(void)
CFE_ES_PerfLogExit(FM_CHILD_TASK_PERF_ID);
}

return;

} /* End of FM_ChildLoop() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -286,8 +282,6 @@ void FM_ChildProcess(void)
FM_GlobalData.ChildQueueCount--;
OS_MutSemGive(FM_GlobalData.ChildQueueCountSem);

return;

} /* End of FM_ChildProcess() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -329,8 +323,6 @@ void FM_ChildCopyCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildCopyCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -371,8 +363,6 @@ void FM_ChildMoveCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildMoveCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -413,8 +403,6 @@ void FM_ChildRenameCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildRenameCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -458,8 +446,6 @@ void FM_ChildDeleteCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildDeleteCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -612,8 +598,6 @@ void FM_ChildDeleteAllCmd(FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildDeleteAllCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -657,8 +641,6 @@ void FM_ChildDecompressCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildDecompressCmd() */

#endif
Expand Down Expand Up @@ -836,8 +818,6 @@ void FM_ChildConcatCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildConcatCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -997,8 +977,6 @@ void FM_ChildFileInfoCmd(FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildFileInfoCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -1039,8 +1017,6 @@ void FM_ChildCreateDirCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildCreateDirCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -1120,8 +1096,6 @@ void FM_ChildDeleteDirCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildDeleteDirCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -1183,8 +1157,6 @@ void FM_ChildDirListFileCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildDirListFileCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -1319,8 +1291,6 @@ void FM_ChildDirListPktCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;

} /* End of FM_ChildDirListPktCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -1357,7 +1327,6 @@ void FM_ChildSetPermissionsCmd(const FM_ChildQueueEntry_t *CmdArgs)
FM_GlobalData.ChildPreviousCC = CmdArgs->CommandCode;
FM_GlobalData.ChildCurrentCC = 0;

return;
} /* End of FM_ChildSetPermissionsCmd() */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -1578,8 +1547,6 @@ void FM_ChildDirListFileLoop(osal_id_t DirId, osal_id_t FileHandle, const char *
(int)DirEntries, Directory, Filename);
}

return;

} /* End of FM_ChildDirListFileLoop */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down
4 changes: 0 additions & 4 deletions fsw/src/fm_cmd_utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -595,8 +595,6 @@ void FM_InvokeChildTask(void)
OS_CountSemGive(FM_GlobalData.ChildSemaphore);
}

return;

} /* End of FM_InvokeChildTask */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -630,8 +628,6 @@ void FM_AppendPathSep(char *Directory, uint32 BufferSize)
}
}

return;

} /* End of FM_AppendPathSep */

/************************/
Expand Down
4 changes: 0 additions & 4 deletions fsw/src/fm_tbl.c
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ void FM_AcquireTablePointers(void)
FM_GlobalData.FreeSpaceTablePtr = (FM_FreeSpaceTable_t *)NULL;
}

return;

} /* End FM_AcquireTablePointers */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand All @@ -220,8 +218,6 @@ void FM_ReleaseTablePointers(void)
/* Prevent table pointer use while released */
FM_GlobalData.FreeSpaceTablePtr = (FM_FreeSpaceTable_t *)NULL;

return;

} /* End FM_ReleaseTablePointers */

/************************/
Expand Down