Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #59, Apply consistent Event ID names to common events #60

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Oct 21, 2022

Checklist

Describe the contribution

Testing performed
Only GitHub CI actions.

Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@thnkslprpt thnkslprpt force-pushed the fix-59-apply-consistent-event-id-names branch 2 times, most recently from d5e14af to 6cdb9b0 Compare March 12, 2023 04:52
@havencarlson
Copy link
Contributor

@thnkslprpt Can you fix the merge conflicts for this pull request?

@thnkslprpt thnkslprpt force-pushed the fix-59-apply-consistent-event-id-names branch 2 times, most recently from 25252d4 to 9890617 Compare March 30, 2023 21:22
@thnkslprpt
Copy link
Contributor Author

@thnkslprpt Can you fix the merge conflicts for this pull request?

All cleared up @havencarlson
Cheers

@thnkslprpt thnkslprpt force-pushed the fix-59-apply-consistent-event-id-names branch from 9890617 to d0a06de Compare November 1, 2023 17:36
@dzbaker dzbaker merged commit 0a9099f into nasa:main Jul 15, 2024
17 checks passed
@thnkslprpt thnkslprpt deleted the fix-59-apply-consistent-event-id-names branch July 16, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Event ID naming
3 participants