Fix #62, Remove initializations causing Cppcheck errors #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #62
Both seem fine to change from initialization at the top of the function to a plain declaration.
StringLength
is used in only oneif
block, and it is assigned a value at its first use in the init-statement of thefor
loop on line 172.Subsequent references to
StringLength
all logically follow this assignment, so the initialization at the top of the function block (line 165) is redundant and can safely be converted to a plain declaration.The same goes for
NameLength
. It is used in only oneif
block, and is assigned a value there at its first use in the init-statement of thefor
loop on line 110. The initialization on line 74 can thus be converted to a simple declaration.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully if separate issue #63 is suppressed
The log from the successful build (with the GCC suppressions that can't be included in this PR) can be viewed here:
https://github.com/thnkslprpt/FM/actions/runs/3404338406/jobs/5661598438
Expected behavior changes
No impact on code behavior.
Cppcheck now passes without error again.
Contributor Info
Avi @thnkslprpt