Merge pull request #17 from skliper/fix16-static_analysis_warnings

Fix #16 #10, Resolve reassignment before use style warnings
nasa · May 11, 2022 · c5ef5ac · c5ef5ac
2 parents 502478e + 367719b
commit c5ef5ac
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/fsw/src/hs_app.c b/fsw/src/hs_app.c
@@ -202,7 +202,7 @@ void HS_AppMain(void)
 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
 int32 HS_AppInit(void)
 {
-    int32 Status = CFE_SUCCESS;
+    int32 Status;
 
     /*
     ** Initialize operating data to default states...
@@ -350,7 +350,7 @@ int32 HS_AppInit(void)
 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
 int32 HS_SbInit(void)
 {
-    int32 Status = CFE_SUCCESS;
+    int32 Status;
 
     /* Initialize housekeeping packet  */
     CFE_MSG_Init(&HS_AppData.HkPacket.TlmHeader.Msg, CFE_SB_ValueToMsgId(HS_HK_TLM_MID), sizeof(HS_HkPacket_t));

diff --git a/fsw/src/hs_cmds.c b/fsw/src/hs_cmds.c
@@ -683,7 +683,7 @@ void HS_SetMaxResetsCmd(const CFE_SB_Buffer_t *BufPtr)
 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
 void HS_AcquirePointers(void)
 {
-    int32 Status = CFE_SUCCESS;
+    int32 Status;
 
     /*
     ** Release the table (AppMon)

diff --git a/fsw/src/hs_custom.c b/fsw/src/hs_custom.c
@@ -87,7 +87,7 @@ void HS_IdleTask(void)
 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
 int32 HS_CustomInit(void)
 {
-    int32 Status = CFE_SUCCESS;
+    int32 Status;
 
     /*
     ** Spawn the Idle Task