Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of compiler extension in table file definitions #66

Closed
2 tasks done
jphickey opened this issue Feb 15, 2023 · 0 comments · Fixed by #67
Closed
2 tasks done

Remove use of compiler extension in table file definitions #66

jphickey opened this issue Feb 15, 2023 · 0 comments · Fixed by #67
Assignees
@jphickey
Labels
enhancement Equuleus-rc1
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
The __attribute__((__used__)) is a GNU compiler extension flag and such constructs should be avoided in portable code.

Describe the solution you'd like
Remove

Additional context
This flag is only in there to avoid a warning due to the use of static - but this object should not be static to begin with, then everything works without the use of special flags.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Feb 15, 2023
jphickey added a commit to jphickey/HS that referenced this issue Feb 15, 2023
@jphickey
Fix nasa#66, remove compiler extensions from tbldefs
1d23a8f 
Do not declare tables as "static" w/attribute "used", neither are
needed, and build works fine without any special sauce.

This also makes the table name consistent by removing the "Default" in
the name - it is still the same table, the name does not need to
change just because it happens to be the default value.
@jphickey jphickey mentioned this issue Feb 15, 2023
Merged
2 tasks
jphickey added a commit to jphickey/HS that referenced this issue Feb 16, 2023
@jphickey
Fix nasa#66, update name of ExeCount Table
cbea300
dzbaker added a commit that referenced this issue Feb 16, 2023
@dzbaker
Merge pull request #67 from jphickey/fix-66-tabledefs
53bf044 
Fix #66, remove compiler extensions from tbldefs
jphickey added a commit to jphickey/HS that referenced this issue Feb 16, 2023
@jphickey
Fix nasa#66, update name of ExeCount Table
96c9f84
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #66, remove compiler extensions from tbldefs jphickey/HS
3 participants
@jphickey @dmknutsen @chillfig