Fix #54, Combine multiple unnecessary status/result variables
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havencarlson
approved these changes
May 12, 2023
|
@thnkslprpt Would you be able to resolve the merge conflict? |
thnkslprpt
force-pushed
the
fix-54-combine-unnecessary-status-variables
branch
from
11b2731
to
258a9b0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
thnkslprpt
force-pushed
the
fix-54-combine-unnecessary-status-variables
branch
from
258a9b0
to
013da07
Compare
All clear now Dylan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
status/resultvariables can be combined #54status/resultvariables holding returns fromCFE_TBL_GetAddress()have been combinedTesting performed
GitHub CI actions all passing successfully.
Expected behavior changes
No change to functional behavior.
Code is simplified - improving future maintainability.
Contributor Info
Avi Weiss @thnkslprpt