Fix #77, deprecate PSP stubs from MD coverage test #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure yet if OMIT_DEPRECATED is enough here, so marking this as a draft. I may need to use a different approach. |
jphickey
force-pushed
the
fix-77-deprecate-psp-stubs
branch
from
c41a991
to
f50c45f
Compare
|
I changed this to be a simple removal of the stubs (not deprecation) because one or the other of the builds will still fail depending on whether or not the PSP is included. There is no easy solution to getting forward+backward compatibility here. The simplest path forward is to simply merge this in the same cycle as nasa/PSP#436 and note the dependency. |
The PSP now provides the complete set of stubs. IMPORTANT: This needs to be used in conjunction with nasa/PSP#436 to get the complete set of stubs, otherwise linking will fail.
jphickey
force-pushed
the
fix-77-deprecate-psp-stubs
branch
from
f50c45f
to
b7ebab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The PSP now provides the complete set of stubs. Local implementation should be removed.
Fixes #77
Testing performed
Build and run all tests
Expected behavior changes
None
System(s) tested on
Debian
Additional context
Needs to be coordinated with nasa/PSP#435
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.